summaryrefslogtreecommitdiffstats
path: root/sound/soc/sof/ipc3-topology.c
diff options
context:
space:
mode:
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>2022-07-08 22:07:19 +0200
committerMark Brown <broonie@kernel.org>2022-07-11 17:16:13 +0200
commitfd1c769d33872d6c7ec474c199f6a910d3555927 (patch)
tree9db1981c59c559b77eba2785b3fe71988bf5c905 /sound/soc/sof/ipc3-topology.c
parentASoC: atmel: mchp-pdmc: remove space in front of mchp_pdmc_dt_init() (diff)
downloadlinux-fd1c769d33872d6c7ec474c199f6a910d3555927.tar.xz
linux-fd1c769d33872d6c7ec474c199f6a910d3555927.zip
ASoC: SOF: remove warning on ABI checks
We should only have an error when enforcing strict mapping between kernel and firmware versions. In all other cases, there is no reason to throw a warning. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Link: https://lore.kernel.org/r/20220708200719.26961-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/sof/ipc3-topology.c')
-rw-r--r--sound/soc/sof/ipc3-topology.c13
1 files changed, 4 insertions, 9 deletions
diff --git a/sound/soc/sof/ipc3-topology.c b/sound/soc/sof/ipc3-topology.c
index 99b62fe7a95c..9448d5338423 100644
--- a/sound/soc/sof/ipc3-topology.c
+++ b/sound/soc/sof/ipc3-topology.c
@@ -2348,15 +2348,10 @@ static int sof_ipc3_parse_manifest(struct snd_soc_component *scomp, int index,
return -EINVAL;
}
- if (SOF_ABI_VERSION_MINOR(abi_version) > SOF_ABI_MINOR) {
- if (!IS_ENABLED(CONFIG_SND_SOC_SOF_STRICT_ABI_CHECKS)) {
- dev_warn(scomp->dev, "%s: Topology ABI is more recent than kernel\n",
- __func__);
- } else {
- dev_err(scomp->dev, "%s: Topology ABI is more recent than kernel\n",
- __func__);
- return -EINVAL;
- }
+ if (IS_ENABLED(CONFIG_SND_SOC_SOF_STRICT_ABI_CHECKS) &&
+ SOF_ABI_VERSION_MINOR(abi_version) > SOF_ABI_MINOR) {
+ dev_err(scomp->dev, "%s: Topology ABI is more recent than kernel\n", __func__);
+ return -EINVAL;
}
return 0;