summaryrefslogtreecommitdiffstats
path: root/sound/soc/stm/stm32_sai.h
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2018-11-02 16:18:21 +0100
committerMark Brown <broonie@kernel.org>2018-11-05 11:37:39 +0100
commit576ce4075bfa0f03e0e91a89eecc539b3b828b08 (patch)
tree963590a4f744316fc785de067d1bc5ad19e32c62 /sound/soc/stm/stm32_sai.h
parentASoC: smd845: constify snd_soc_ops structure (diff)
downloadlinux-576ce4075bfa0f03e0e91a89eecc539b3b828b08.tar.xz
linux-576ce4075bfa0f03e0e91a89eecc539b3b828b08.zip
ASoC: wm97xx: fix uninitialized regmap pointer problem
gcc notices that without either the ac97 bus or the pdata, we never initialize the regmap pointer, which leads to an uninitialized variable access: sound/soc/codecs/wm9712.c: In function 'wm9712_soc_probe': sound/soc/codecs/wm9712.c:666:2: error: 'regmap' may be used uninitialized in this function [-Werror=maybe-uninitialized] Since that configuration is invalid, it's better to return an error here. I tried to avoid adding complexity to the conditions, and turned the #ifdef into a regular if(IS_ENABLED()) check for readability. This in turn requires moving some header file declarations out of an #ifdef. The same code is used in three drivers, all of which I'm changing the same way. Fixes: 2ed1a8e0ce8d ("ASoC: wm9712: add ac97 new bus support") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/stm/stm32_sai.h')
0 files changed, 0 insertions, 0 deletions