summaryrefslogtreecommitdiffstats
path: root/sound/soc
diff options
context:
space:
mode:
authorshengjiu wang <shengjiu.wang@nxp.com>2020-12-16 11:44:24 +0100
committerMark Brown <broonie@kernel.org>2020-12-16 14:53:52 +0100
commitacd894aee3149c15847bc4f0690fccba59ced5e7 (patch)
treea2a70d5b4ab8715696838fb6cbec99256e5d78f8 /sound/soc
parentASoC: SOF: Fix spelling mistake in Kconfig "ond" -> "and" (diff)
downloadlinux-acd894aee3149c15847bc4f0690fccba59ced5e7.tar.xz
linux-acd894aee3149c15847bc4f0690fccba59ced5e7.zip
ASoC: imx-hdmi: Fix warning of the uninitialized variable ret
When condition ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) is true, then goto fail, the uninitialized variable ret will be returned. Signed-off-by: shengjiu wang <shengjiu.wang@nxp.com> Reported-by: kernel test robot <lkp@intel.com> Acked-by: Nicolin Chen <nicoleotsuka@gmail.com> Fixes: 6a5f850aa83a ("ASoC: fsl: Add imx-hdmi machine driver") Reviewed-by: Fabio Estevam <festevam@gmail.com> Link: https://lore.kernel.org/r/1608115464-18710-1-git-send-email-shengjiu.wang@nxp.com Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc')
-rw-r--r--sound/soc/fsl/imx-hdmi.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c
index 2c2a76a71940..ede4a9ad1054 100644
--- a/sound/soc/fsl/imx-hdmi.c
+++ b/sound/soc/fsl/imx-hdmi.c
@@ -164,6 +164,7 @@ static int imx_hdmi_probe(struct platform_device *pdev)
if ((hdmi_out && hdmi_in) || (!hdmi_out && !hdmi_in)) {
dev_err(&pdev->dev, "Invalid HDMI DAI link\n");
+ ret = -EINVAL;
goto fail;
}