diff options
| author | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> | 2016-08-16 12:24:46 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2016-08-16 12:52:31 +0200 |
| commit | b0f12c61de013ecb0abe19d5e64bdab45989de5a (patch) | |
| tree | 3eeb6097e290b8103cc6dd738796eb09630b39c9 /sound/soc | |
| parent | Linux 4.8-rc1 (diff) | |
| download | linux-b0f12c61de013ecb0abe19d5e64bdab45989de5a.tar.xz linux-b0f12c61de013ecb0abe19d5e64bdab45989de5a.zip | |
ASoC: compress: Fix leak of a widget list in soc_compr_open_fe
After we have called dpcm_path_get we should make sure to call
dpcm_path_put on all error paths. This was not happening causing the
allocated widget list to be leaked, this patch corrects this by adding a
dpcm_path_put to the error path.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc')
| -rw-r--r-- | sound/soc/soc-compress.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c index d2df46c14c68..bf7b52fce597 100644 --- a/sound/soc/soc-compress.c +++ b/sound/soc/soc-compress.c @@ -121,7 +121,7 @@ static int soc_compr_open_fe(struct snd_compr_stream *cstream) dpcm_be_disconnect(fe, stream); fe->dpcm[stream].runtime = NULL; - goto fe_err; + goto path_err; } dpcm_clear_pending_state(fe, stream); @@ -136,6 +136,8 @@ static int soc_compr_open_fe(struct snd_compr_stream *cstream) return 0; +path_err: + dpcm_path_put(&list); fe_err: if (fe->dai_link->compr_ops && fe->dai_link->compr_ops->shutdown) fe->dai_link->compr_ops->shutdown(cstream); |