diff options
| author | Eric Sesterhenn <snakebyte@gmx.de> | 2006-05-31 11:55:17 +0200 |
|---|---|---|
| committer | Jaroslav Kysela <perex@suse.cz> | 2006-06-22 21:34:05 +0200 |
| commit | d20cad602fc3d92902dc3b4ed252359ab05eae0f (patch) | |
| tree | b2a2c5ffd6b94317ea26a7a349d44993d95d6dce /sound/synth/emux/soundfont.c | |
| parent | [ALSA] cmipci - Fix a typo in 'PC Speaker Playback Switch' control (diff) | |
| download | linux-d20cad602fc3d92902dc3b4ed252359ab05eae0f.tar.xz linux-d20cad602fc3d92902dc3b4ed252359ab05eae0f.zip | |
[ALSA] NULL pointer dereference in sound/synth/emux/soundfont.c
this is about coverity id #100.
It seems the if statement is negated, since the else branch calls
remove_info() with sflist->currsf as a parameter where it gets
dereferenced.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/synth/emux/soundfont.c')
| -rw-r--r-- | sound/synth/emux/soundfont.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/synth/emux/soundfont.c b/sound/synth/emux/soundfont.c index 7f0bdea0dfd3..455e535933ec 100644 --- a/sound/synth/emux/soundfont.c +++ b/sound/synth/emux/soundfont.c @@ -195,7 +195,7 @@ snd_soundfont_load(struct snd_sf_list *sflist, const void __user *data, break; case SNDRV_SFNT_REMOVE_INFO: /* patch must be opened */ - if (sflist->currsf) { + if (!sflist->currsf) { snd_printk("soundfont: remove_info: patch not opened\n"); rc = -EINVAL; } else { |