diff options
| author | Richard Fitzgerald <rf@opensource.cirrus.com> | 2024-05-08 12:08:11 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2024-05-08 18:18:29 +0200 |
| commit | d344873c4cbde249b7152d36a273bcc45864001e (patch) | |
| tree | c475e47422c4af696a125b0466399834569f5df5 /sound/usb/card.c | |
| parent | ALSA: hda: hda_component: Initialize shared data during bind callback (diff) | |
| download | linux-d344873c4cbde249b7152d36a273bcc45864001e.tar.xz linux-d344873c4cbde249b7152d36a273bcc45864001e.zip | |
ALSA: hda: cs35l56: Fix lifetime of cs_dsp instance
The cs_dsp instance is initialized in the driver probe() so it
should be freed in the driver remove(). Also fix a missing call
to cs_dsp_remove() in the error path of cs35l56_hda_common_probe().
The call to cs_dsp_remove() was being done in the component unbind
callback cs35l56_hda_unbind(). This meant that if the driver was
unbound and then re-bound it would be using an uninitialized cs_dsp
instance.
It is best to initialize the cs_dsp instance in probe() so that it
can return an error if it fails. The component binding API doesn't
have any error handling so there's no way to handle a failure if
cs_dsp was initialized in the bind.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")
Link: https://lore.kernel.org/r/20240508100811.49514-1-rf@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb/card.c')
0 files changed, 0 insertions, 0 deletions