diff options
| author | Dongxiang Ke <kdx.glider@gmail.com> | 2022-09-06 04:49:28 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2022-09-06 07:14:32 +0200 |
| commit | e53f47f6c1a56d2af728909f1cb894da6b43d9bf (patch) | |
| tree | a065b80b59cf43f2cbe60c93e52f47c6c05f549e /sound/usb/stream.c | |
| parent | ALSA: hda/tegra: Align BDL entry to 4KB boundary (diff) | |
| download | linux-e53f47f6c1a56d2af728909f1cb894da6b43d9bf.tar.xz linux-e53f47f6c1a56d2af728909f1cb894da6b43d9bf.zip | |
ALSA: usb-audio: Fix an out-of-bounds bug in __snd_usb_parse_audio_interface()
There may be a bad USB audio device with a USB ID of (0x04fa, 0x4201) and
the number of it's interfaces less than 4, an out-of-bounds read bug occurs
when parsing the interface descriptor for this device.
Fix this by checking the number of interfaces.
Signed-off-by: Dongxiang Ke <kdx.glider@gmail.com>
Link: https://lore.kernel.org/r/20220906024928.10951-1-kdx.glider@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb/stream.c')
| -rw-r--r-- | sound/usb/stream.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/usb/stream.c b/sound/usb/stream.c index 40b7821c6c99..f10f4e6d3fb8 100644 --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -1106,7 +1106,7 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip, * Dallas DS4201 workaround: It presents 5 altsettings, but the last * one misses syncpipe, and does not produce any sound. */ - if (chip->usb_id == USB_ID(0x04fa, 0x4201)) + if (chip->usb_id == USB_ID(0x04fa, 0x4201) && num >= 4) num = 4; for (i = 0; i < num; i++) { |