diff options
| author | Takashi Iwai <tiwai@suse.de> | 2022-08-01 18:54:20 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-08-05 13:57:24 +0200 |
| commit | 94c1ceb043c1a002de9649bb630c8e8347645982 (patch) | |
| tree | e49d49ffa96091d16bfe72238124b6aeab7cfbb9 /sound | |
| parent | ASoC: SOF: debug: Fix potential buffer overflow by snprintf() (diff) | |
| download | linux-94c1ceb043c1a002de9649bb630c8e8347645982.tar.xz linux-94c1ceb043c1a002de9649bb630c8e8347645982.zip | |
ASoC: SOF: Intel: hda: Fix potential buffer overflow by snprintf()
snprintf() returns the would-be-filled size when the string overflows
the given buffer size, hence using this value may result in the buffer
overflow (although it's unrealistic).
This patch replaces with a safer version, scnprintf() for papering
over such a potential issue.
Fixes: 29c8e4398f02 ("ASoC: SOF: Intel: hda: add extended rom status dump to error log")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20220801165420.25978-4-tiwai@suse.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/sof/intel/hda.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c index 8639ea63a10d..6d4ecbe14adf 100644 --- a/sound/soc/sof/intel/hda.c +++ b/sound/soc/sof/intel/hda.c @@ -574,7 +574,7 @@ static void hda_dsp_dump_ext_rom_status(struct snd_sof_dev *sdev, const char *le chip = get_chip_info(sdev->pdata); for (i = 0; i < HDA_EXT_ROM_STATUS_SIZE; i++) { value = snd_sof_dsp_read(sdev, HDA_DSP_BAR, chip->rom_status_reg + i * 0x4); - len += snprintf(msg + len, sizeof(msg) - len, " 0x%x", value); + len += scnprintf(msg + len, sizeof(msg) - len, " 0x%x", value); } dev_printk(level, sdev->dev, "extended rom status: %s", msg); |