diff options
| author | Cezary Rojewski <cezary.rojewski@intel.com> | 2020-11-16 14:33:28 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-11-16 21:03:27 +0100 |
| commit | aa9e3fa4992d83acb7311fc86d11d0d53e7ffb8e (patch) | |
| tree | 2b6a995171d9fde721f62d7f5877660ae4bf71c1 /sound | |
| parent | Linux 5.10-rc1 (diff) | |
| download | linux-aa9e3fa4992d83acb7311fc86d11d0d53e7ffb8e.tar.xz linux-aa9e3fa4992d83acb7311fc86d11d0d53e7ffb8e.zip | |
ASoC: Intel: catpt: Skip position update for unprepared streams
Playing with very low period sizes may lead to timeouts when awaiting
RESET_STREAM reply for offload streams. This is caused by NOTIFY_POSITION
appearing in the middle of trigger(stop).
Stream is unprepared during trigger(stop) where PAUSE_STREAM IPC gets
invoked. However, all data that is already mixed in DSP firmware's mixer
stream will still be played regardless of the pause. For offload streams,
this means possibility for another NOTIFY_POSITION to process. Keep these
notifications in check by only handling them when stream is in prepared
state.
Fixes: a126750fc865 ("ASoC: Intel: catpt: PCM operations")
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20201116133332.8530-2-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/intel/catpt/pcm.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sound/soc/intel/catpt/pcm.c b/sound/soc/intel/catpt/pcm.c index f78018c857b8..174a786cd776 100644 --- a/sound/soc/intel/catpt/pcm.c +++ b/sound/soc/intel/catpt/pcm.c @@ -534,6 +534,8 @@ void catpt_stream_update_position(struct catpt_dev *cdev, dsppos = bytes_to_frames(r, pos->stream_position); + if (!stream->prepared) + goto exit; /* only offload is set_write_pos driven */ if (stream->template->type != CATPT_STRM_TYPE_RENDER) goto exit; |