diff options
| author | Charles Keepax <ckeepax@opensource.wolfsonmicro.com> | 2017-03-06 17:54:34 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2017-03-07 13:07:59 +0100 |
| commit | 7b4af793a7a4f8e04175eb6600ba9c8ba855ad20 (patch) | |
| tree | 2e59248845b785171d5575af03e56995a5763ad6 /sound | |
| parent | ASoC: wm_adsp: Return an error on write to a disabled volatile control (diff) | |
| download | linux-7b4af793a7a4f8e04175eb6600ba9c8ba855ad20.tar.xz linux-7b4af793a7a4f8e04175eb6600ba9c8ba855ad20.zip | |
ASoC: wm_adsp: Acknowledge controls should also check the DSP is running
We should not be writing acknowledge controls until the firmware is
running, as in the case of preloaded firmwares the DSP memory may be
unaccessible to whilst in the preloaded state. This means a write to the
control during this time could be lost.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/codecs/wm_adsp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c index 6313b3da967b..bbdb72f73df1 100644 --- a/sound/soc/codecs/wm_adsp.c +++ b/sound/soc/codecs/wm_adsp.c @@ -952,7 +952,7 @@ static int wm_coeff_put_acked(struct snd_kcontrol *kctl, mutex_lock(&ctl->dsp->pwr_lock); - if (ctl->enabled) + if (ctl->enabled && ctl->dsp->running) ret = wm_coeff_write_acked_control(ctl, val); else ret = -EPERM; |