summaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2023-09-13 10:18:22 +0200
committerMark Brown <broonie@kernel.org>2023-09-13 14:58:24 +0200
commitcf0ba445f5e4dd74c1e9d7a83ca721ba69204a11 (patch)
treeb0d9bc72faac05760c6db34c7d2b40af1981050c /sound
parentASoC: rt5640: Fix various IRQ handling issues (diff)
downloadlinux-cf0ba445f5e4dd74c1e9d7a83ca721ba69204a11.tar.xz
linux-cf0ba445f5e4dd74c1e9d7a83ca721ba69204a11.zip
ASoC: codecs: aw88395: Fix some error codes
These error paths should return -EINVAL instead of success. Fixes: 7f4ec77802aa ("ASoC: codecs: Add code for bin parsing compatible with aw88261") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/81476e78-05c2-4656-b754-f314c7ccdb81@moroto.mountain Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
-rw-r--r--sound/soc/codecs/aw88395/aw88395_lib.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/sound/soc/codecs/aw88395/aw88395_lib.c b/sound/soc/codecs/aw88395/aw88395_lib.c
index 8ee1baa03269..87dd0ccade4c 100644
--- a/sound/soc/codecs/aw88395/aw88395_lib.c
+++ b/sound/soc/codecs/aw88395/aw88395_lib.c
@@ -452,11 +452,13 @@ static int aw_dev_parse_reg_bin_with_hdr(struct aw_device *aw_dev,
if ((aw_bin->all_bin_parse_num != 1) ||
(aw_bin->header_info[0].bin_data_type != DATA_TYPE_REGISTER)) {
dev_err(aw_dev->dev, "bin num or type error");
+ ret = -EINVAL;
goto parse_bin_failed;
}
if (aw_bin->header_info[0].valid_data_len % 4) {
dev_err(aw_dev->dev, "bin data len get error!");
+ ret = -EINVAL;
goto parse_bin_failed;
}