diff options
| author | Jiri Olsa <jolsa@redhat.com> | 2016-01-28 20:13:24 +0100 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-01-28 23:04:19 +0100 |
| commit | 76c4aaec41b76afb7f914aaf6080f21ab331b0c6 (patch) | |
| tree | 87bb301bb3ece30ed0330a7244b2b50c7b6e55bc /tools/build | |
| parent | tools build: Check basic headers for test-compile feature checker (diff) | |
| download | linux-76c4aaec41b76afb7f914aaf6080f21ab331b0c6.tar.xz linux-76c4aaec41b76afb7f914aaf6080f21ab331b0c6.zip | |
perf build: Fix feature-dump checks, we need to test all features
I see problem with test-all case speedup, because it does not
comprise checks for 32bits compilations, fix it.
The problem could be noticed by calling:
make -C tools/perf feature-dump
That would end up misdetecting the feature-compile-x32, that, building
using 'gcc -mx32' needs stub headers not present in a fedora 23 devel
machine and thus fail to compile, but ended up appearing as detected,
i.e. present in tools/perf/FEATURE-DUMP as 'feature-compile-x32=1'.
With this fix it correctly appears as 'feature-compile-x32=0' and if we
uninstall the libc devel files for 32 bits (glibc-devel.i686), then the
relevant variable is flipped from 'feature-compile-32=1' to
'feature-compile-32=0'.
The same things happened for bionic and libbabeltrace, that were
misdetected because the are no tested in test-all.c
Reported-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-u0sjaddf1r9m8icpd98ry7fz@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/build')
| -rw-r--r-- | tools/build/Makefile.feature | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature index 674c47d5f9d1..7bff2ea831cf 100644 --- a/tools/build/Makefile.feature +++ b/tools/build/Makefile.feature @@ -119,6 +119,14 @@ ifeq ($(feature-all), 1) # test-all.c passed - just set all the core feature flags to 1: # $(foreach feat,$(FEATURE_TESTS),$(call feature_set,$(feat))) + # + # test-all.c does not comprise these tests, so we need to + # for this case to get features proper values + # + $(call feature_check,compile-32) + $(call feature_check,compile-x32) + $(call feature_check,bionic) + $(call feature_check,libbabeltrace) else $(foreach feat,$(FEATURE_TESTS),$(call feature_check,$(feat))) endif |