diff options
| author | Alexey Dobriyan <adobriyan@gmail.com> | 2020-05-07 22:07:04 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2020-05-10 00:07:58 +0200 |
| commit | a8de6639169b90e3dc4f27e752a3c5abac5e90da (patch) | |
| tree | 8d8734baf42b3aaa451e54415fef1f799c8176d9 /tools/cgroup | |
| parent | bdi: add a ->dev_name field to struct backing_dev_info (diff) | |
| download | linux-a8de6639169b90e3dc4f27e752a3c5abac5e90da.tar.xz linux-a8de6639169b90e3dc4f27e752a3c5abac5e90da.zip | |
nvme-pci: fix "slimmer CQ head update"
Pre-incrementing ->cq_head can't be done in memory because OOB value
can be observed by another context.
This devalues space savings compared to original code :-\
$ ./scripts/bloat-o-meter ../vmlinux-000 ../obj/vmlinux
add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-32 (-32)
Function old new delta
nvme_poll_irqdisable 464 456 -8
nvme_poll 455 447 -8
nvme_irq 388 380 -8
nvme_dev_disable 955 947 -8
But the code is minimal now: one read for head, one read for q_depth,
one increment, one comparison, single instruction phase bit update and
one write for new head.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Reported-by: John Garry <john.garry@huawei.com>
Tested-by: John Garry <john.garry@huawei.com>
Fixes: e2a366a4b0feaeb ("nvme-pci: slimmer CQ head update")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'tools/cgroup')
0 files changed, 0 insertions, 0 deletions