diff options
author | Tang Junhui <tang.junhui@zte.com.cn> | 2017-09-06 08:25:52 +0200 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2017-09-06 16:17:33 +0200 |
commit | c81ffa32a214c84b08900fbc9d432187bd948eba (patch) | |
tree | ab00291fe74fbaa552bc3cd7a679492ac74430bc /tools/gpio | |
parent | bcache: Fix leak of bdev reference (diff) | |
download | linux-c81ffa32a214c84b08900fbc9d432187bd948eba.tar.xz linux-c81ffa32a214c84b08900fbc9d432187bd948eba.zip |
bcache: fix sequential large write IO bypass
Sequential write IOs were tested with bs=1M by FIO in writeback cache
mode, these IOs were expected to be bypassed, but actually they did not.
We debug the code, and find in check_should_bypass():
if (!congested &&
mode == CACHE_MODE_WRITEBACK &&
op_is_write(bio_op(bio)) &&
(bio->bi_opf & REQ_SYNC))
goto rescale
that means, If in writeback mode, a write IO with REQ_SYNC flag will not
be bypassed though it is a sequential large IO, It's not a correct thing
to do actually, so this patch remove these codes.
Signed-off-by: tang.junhui <tang.junhui@zte.com.cn>
Reviewed-by: Kent Overstreet <kent.overstreet@gmail.com>
Reviewed-by: Eric Wheeler <bcache@linux.ewheeler.net>
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'tools/gpio')
0 files changed, 0 insertions, 0 deletions