diff options
author | Jan Kara <jack@suse.cz> | 2024-06-25 12:18:57 +0200 |
---|---|---|
committer | Andrew Morton <akpm@linux-foundation.org> | 2024-07-04 04:30:27 +0200 |
commit | 0b1efc3e78d12278a8c0f2c665d66564a2cb965f (patch) | |
tree | ff4cb81950e837b23618c822947ffc206b99e837 /tools/leds | |
parent | readahead: drop dead code in page_cache_ra_order() (diff) | |
download | linux-0b1efc3e78d12278a8c0f2c665d66564a2cb965f.tar.xz linux-0b1efc3e78d12278a8c0f2c665d66564a2cb965f.zip |
readahead: drop dead code in ondemand_readahead()
ondemand_readahead() scales up the readahead window if the current read
would hit the readahead mark placed by itself. However the condition is
mostly dead code because:
a) In case of async readahead we always increase ra->start so ra->start
== index is never true.
b) In case of sync readahead we either go through
try_context_readahead() in which case ra->async_size == 1 < ra->size or
we go through initial_readahead where ra->async_size == ra->size iff
ra->size == max_pages.
So the only practical effect is reducing async_size for large initial
reads. Make the code more obvious.
Link: https://lkml.kernel.org/r/20240625101909.12234-7-jack@suse.cz
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Tested-by: Zhang Peng <zhangpengpeng0808@gmail.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'tools/leds')
0 files changed, 0 insertions, 0 deletions