diff options
author | Christophe Leroy <christophe.leroy@csgroup.eu> | 2022-11-14 18:57:46 +0100 |
---|---|---|
committer | Michael Ellerman <mpe@ellerman.id.au> | 2022-11-18 09:00:15 +0100 |
commit | efb11fdb3e1a9f694fa12b70b21e69e55ec59c36 (patch) | |
tree | 8b45eb990e937c210de8975c1d1877c5cb6cd8ae /tools/objtool | |
parent | powerpc/vdso: Skip objtool from running on VDSO files (diff) | |
download | linux-efb11fdb3e1a9f694fa12b70b21e69e55ec59c36.tar.xz linux-efb11fdb3e1a9f694fa12b70b21e69e55ec59c36.zip |
objtool: Fix SEGFAULT
find_insn() will return NULL in case of failure. Check insn in order
to avoid a kernel Oops for NULL pointer dereference.
Tested-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Reviewed-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221114175754.1131267-9-sv@linux.ibm.com
Diffstat (limited to 'tools/objtool')
-rw-r--r-- | tools/objtool/check.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 43ec14c29a60..8427af808221 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -207,7 +207,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, return false; insn = find_insn(file, func->sec, func->offset); - if (!insn->func) + if (!insn || !insn->func) return false; func_for_each_insn(file, func, insn) { |