diff options
author | Anton Blanchard <anton@samba.org> | 2010-05-04 13:19:15 +0200 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-05-04 15:54:09 +0200 |
commit | 02bf60aad7d5912dfcdbe0154f1bd67ea7a8301e (patch) | |
tree | 4d0c009e30079b127e0d7b01cdd30d8375e44c7c /tools/perf/Documentation | |
parent | perf inject: Add missing bits (diff) | |
download | linux-02bf60aad7d5912dfcdbe0154f1bd67ea7a8301e.tar.xz linux-02bf60aad7d5912dfcdbe0154f1bd67ea7a8301e.zip |
perf: Fix performance issue with perf report
On a large machine we spend a lot of time in perf_header__find_attr when
running perf report.
If we are parsing a file without PERF_SAMPLE_ID then for each sample we call
perf_header__find_attr and loop through all counter IDs, never finding a match.
As the machine gets larger there are more per cpu counters and we spend an
awful lot of time in there.
The patch below initialises each sample id to -1ULL and checks for this in
perf_header__find_attr. We may need to do something more intelligent eventually
(eg a hash lookup from counter id to attr) but this at least fixes the most
common usage of perf report.
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Eric B Munson <ebmunson@us.ibm.com>
Acked-by: Eric B Munson <ebmunson@us.ibm.com>
LKML-Reference: <20100504111915.GB14636@kryten>
Signed-off-by: Anton Blanchard <anton@samba.org>
--
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/Documentation')
0 files changed, 0 insertions, 0 deletions