summaryrefslogtreecommitdiffstats
path: root/tools/perf/builtin-mem.c
diff options
context:
space:
mode:
authorMartin Kepplinger <martink@posteo.de>2017-09-13 21:14:19 +0200
committerArnaldo Carvalho de Melo <acme@redhat.com>2017-09-18 14:40:21 +0200
commitc896f85a7c15ab9d040ffac8b8003e47996602a2 (patch)
treef65e995175ee475efdb93622228ba5425a8ec8c1 /tools/perf/builtin-mem.c
parentperf pmu: Improve error messages for missing PMUs (diff)
downloadlinux-c896f85a7c15ab9d040ffac8b8003e47996602a2.tar.xz
linux-c896f85a7c15ab9d040ffac8b8003e47996602a2.zip
perf tools: Fix leaking rec_argv in error cases
Let's free the allocated rec_argv in case we return early, in order to avoid leaking memory. This adds free() at a few very similar places across the tree where it was missing. Signed-off-by: Martin Kepplinger <martink@posteo.de> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Martin kepplinger <martink@posteo.de> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/20170913191419.29806-1-martink@posteo.de Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-mem.c')
-rw-r--r--tools/perf/builtin-mem.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c
index 0f15634ef82c..6940490bc3f9 100644
--- a/tools/perf/builtin-mem.c
+++ b/tools/perf/builtin-mem.c
@@ -112,6 +112,7 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem)
if (!perf_mem_events[j].supported) {
pr_err("failed: event '%s' not supported\n",
perf_mem_events__name(j));
+ free(rec_argv);
return -1;
}