diff options
| author | Ian Rogers <irogers@google.com> | 2024-02-01 01:15:02 +0100 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2024-02-10 05:43:13 +0100 |
| commit | c7ba9d18ae47924a6ea6a47ca139779f58eb83c0 (patch) | |
| tree | eefd85b1ebe7aa6952b2f76a79186452bafc5875 /tools/perf/util/srcline.c | |
| parent | perf stat: Support per-cluster aggregation (diff) | |
| download | linux-c7ba9d18ae47924a6ea6a47ca139779f58eb83c0.tar.xz linux-c7ba9d18ae47924a6ea6a47ca139779f58eb83c0.zip | |
perf srcline: Add missed addr2line closes
The child_process for addr2line sets in and out to -1 so that pipes
get created. It is the caller's responsibility to close the pipes,
finish_command doesn't do it. Add the missed closes.
Fixes: b3801e791231 ("perf srcline: Simplify addr2line subprocess")
Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: James Clark <james.clark@arm.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Tom Rix <trix@redhat.com>
Cc: llvm@lists.linux.dev
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240201001504.1348511-8-irogers@google.com
Diffstat (limited to 'tools/perf/util/srcline.c')
| -rw-r--r-- | tools/perf/util/srcline.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c index 034b496df297..7addc34afcf5 100644 --- a/tools/perf/util/srcline.c +++ b/tools/perf/util/srcline.c @@ -399,6 +399,8 @@ static void addr2line_subprocess_cleanup(struct child_process *a2l) kill(a2l->pid, SIGKILL); finish_command(a2l); /* ignore result, we don't care */ a2l->pid = -1; + close(a2l->in); + close(a2l->out); } free(a2l); |