diff options
| author | Daniel Latypov <dlatypov@google.com> | 2021-09-30 01:25:34 +0200 |
|---|---|---|
| committer | Shuah Khan <skhan@linuxfoundation.org> | 2021-10-19 22:18:50 +0200 |
| commit | fe678fed2cda4c74d016171dce290b792b036663 (patch) | |
| tree | fe3bd582f0c8cfa0941357144b7f249d695758eb /tools/testing/kunit/kunit_tool_test.py | |
| parent | kunit: tool: misc fixes (unused vars, imports, leaked files) (diff) | |
| download | linux-fe678fed2cda4c74d016171dce290b792b036663.tar.xz linux-fe678fed2cda4c74d016171dce290b792b036663.zip | |
kunit: tool: show list of valid --arch options when invalid
Consider this attempt to run KUnit in QEMU:
$ ./tools/testing/kunit/kunit.py run --arch=x86
Before you'd get this error message:
kunit_kernel.ConfigError: x86 is not a valid arch
After:
kunit_kernel.ConfigError: x86 is not a valid arch, options are ['alpha', 'arm', 'arm64', 'i386', 'powerpc', 'riscv', 's390', 'sparc', 'x86_64']
This should make it a bit easier for people to notice when they make
typos, etc. Currently, one would have to dive into the python code to
figure out what the valid set is.
Signed-off-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: David Gow <davidgow@google.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'tools/testing/kunit/kunit_tool_test.py')
| -rwxr-xr-x | tools/testing/kunit/kunit_tool_test.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tools/testing/kunit/kunit_tool_test.py b/tools/testing/kunit/kunit_tool_test.py index bc6b85db6beb..1116882ddf69 100755 --- a/tools/testing/kunit/kunit_tool_test.py +++ b/tools/testing/kunit/kunit_tool_test.py @@ -289,6 +289,10 @@ class LinuxSourceTreeTest(unittest.TestCase): pass kunit_kernel.LinuxSourceTree('', kunitconfig_path=dir) + def test_invalid_arch(self): + with self.assertRaisesRegex(kunit_kernel.ConfigError, 'not a valid arch, options are.*x86_64'): + kunit_kernel.LinuxSourceTree('', arch='invalid') + # TODO: add more test cases. |