summaryrefslogtreecommitdiffstats
path: root/tools/testing/kunit/qemu_config.py
diff options
context:
space:
mode:
authorDaniel Latypov <dlatypov@google.com>2022-01-18 20:09:21 +0100
committerShuah Khan <skhan@linuxfoundation.org>2022-04-04 22:25:53 +0200
commite6f61920653925e6fa9aceb5cdb47ecf543986c8 (patch)
treececb0e7e59bb67ed4c0d5ec93cc17836b50d0a38 /tools/testing/kunit/qemu_config.py
parentkunit: tool: drop unused KernelDirectoryPath var (diff)
downloadlinux-e6f61920653925e6fa9aceb5cdb47ecf543986c8.tar.xz
linux-e6f61920653925e6fa9aceb5cdb47ecf543986c8.zip
kunit: tool: drop last uses of collections.namedtuple
Since we formally require python3.7+ since commit df4b0807ca1a ("kunit: tool: Assert the version requirement"), we can just use @dataclasses.dataclass instead. In kunit_config.py, we used namedtuple to create a hashable type that had `name` and `value` fields and had to subclass it to define a custom `__str__()`. @datalcass lets us just define one type instead. In qemu_config.py, we use namedtuple to allow modules to define various parameters. Using @dataclass, we can add type-annotations for all these fields, making our code more typesafe and making it easier for users to figure out how to define new configs. Signed-off-by: Daniel Latypov <dlatypov@google.com> Reviewed-by: David Gow <davidgow@google.com> Reviewed-by: Brendan Higgins <brendanhiggins@google.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'tools/testing/kunit/qemu_config.py')
-rw-r--r--tools/testing/kunit/qemu_config.py17
1 files changed, 10 insertions, 7 deletions
diff --git a/tools/testing/kunit/qemu_config.py b/tools/testing/kunit/qemu_config.py
index 1672f6184e95..0b6a80398ccc 100644
--- a/tools/testing/kunit/qemu_config.py
+++ b/tools/testing/kunit/qemu_config.py
@@ -5,12 +5,15 @@
# Copyright (C) 2021, Google LLC.
# Author: Brendan Higgins <brendanhiggins@google.com>
-from collections import namedtuple
+from dataclasses import dataclass
+from typing import List
-QemuArchParams = namedtuple('QemuArchParams', ['linux_arch',
- 'kconfig',
- 'qemu_arch',
- 'kernel_path',
- 'kernel_command_line',
- 'extra_qemu_params'])
+@dataclass(frozen=True)
+class QemuArchParams:
+ linux_arch: str
+ kconfig: str
+ qemu_arch: str
+ kernel_path: str
+ kernel_command_line: str
+ extra_qemu_params: List[str]