summaryrefslogtreecommitdiffstats
path: root/tools/testing/selftests/bpf/prog_tests/attach_probe.c
diff options
context:
space:
mode:
authorAlexei Starovoitov <ast@kernel.org>2019-12-19 03:04:42 +0100
committerDaniel Borkmann <daniel@iogearbox.net>2019-12-19 16:14:08 +0100
commit580205dd4fe800b1e95be8b6df9e2991f975a8ad (patch)
tree839332253b6b6970c1f4f128b0a335c974fb7226 /tools/testing/selftests/bpf/prog_tests/attach_probe.c
parentlibbpf: Add missing newline in opts validation macro (diff)
downloadlinux-580205dd4fe800b1e95be8b6df9e2991f975a8ad.tar.xz
linux-580205dd4fe800b1e95be8b6df9e2991f975a8ad.zip
selftests/bpf: Fix test_attach_probe
Fix two issues in test_attach_probe: 1. it was not able to parse /proc/self/maps beyond the first line, since %s means parse string until white space. 2. offset has to be accounted for otherwise uprobed address is incorrect. Fixes: 1e8611bbdfc9 ("selftests/bpf: add kprobe/uprobe selftests") Signed-off-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Yonghong Song <yhs@fb.com> Acked-by: Andrii Nakryiko <andriin@fb.com> Link: https://lore.kernel.org/bpf/20191219020442.1922617-1-ast@kernel.org
Diffstat (limited to 'tools/testing/selftests/bpf/prog_tests/attach_probe.c')
-rw-r--r--tools/testing/selftests/bpf/prog_tests/attach_probe.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/tools/testing/selftests/bpf/prog_tests/attach_probe.c b/tools/testing/selftests/bpf/prog_tests/attach_probe.c
index 5ed90ede2f1d..a0ee87c8e1ea 100644
--- a/tools/testing/selftests/bpf/prog_tests/attach_probe.c
+++ b/tools/testing/selftests/bpf/prog_tests/attach_probe.c
@@ -3,7 +3,7 @@
#include "test_attach_probe.skel.h"
ssize_t get_base_addr() {
- size_t start;
+ size_t start, offset;
char buf[256];
FILE *f;
@@ -11,10 +11,11 @@ ssize_t get_base_addr() {
if (!f)
return -errno;
- while (fscanf(f, "%zx-%*x %s %*s\n", &start, buf) == 2) {
+ while (fscanf(f, "%zx-%*x %s %zx %*[^\n]\n",
+ &start, buf, &offset) == 3) {
if (strcmp(buf, "r-xp") == 0) {
fclose(f);
- return start;
+ return start - offset;
}
}