diff options
| author | Lucas Bates <lucasb@mojatatu.com> | 2017-10-13 23:51:25 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-10-15 03:47:53 +0200 |
| commit | 7f6661a78a50c3bae8c9f71f67487abbea64dbb3 (patch) | |
| tree | 829913224a2532b047fcfcc08da2de63b33dded8 /tools/testing/selftests/tc-testing | |
| parent | tc-testing: Add test cases for police and skbmod (diff) | |
| download | linux-7f6661a78a50c3bae8c9f71f67487abbea64dbb3.tar.xz linux-7f6661a78a50c3bae8c9f71f67487abbea64dbb3.zip | |
tc-testing: fix the -l argument bug in tdc.py
This patch fixes a bug in the tdc script, where executing tdc
with the -l argument would cause the tests to start running
as opposed to listing all the known test cases.
Signed-off-by: Lucas Bates <lucasb@mojatatu.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/testing/selftests/tc-testing')
| -rwxr-xr-x | tools/testing/selftests/tc-testing/tdc.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tools/testing/selftests/tc-testing/tdc.py b/tools/testing/selftests/tc-testing/tdc.py index cd61b7844c0d..d2391df2cf7d 100755 --- a/tools/testing/selftests/tc-testing/tdc.py +++ b/tools/testing/selftests/tc-testing/tdc.py @@ -49,7 +49,7 @@ def exec_cmd(command, nsonly=True): stderr=subprocess.PIPE) (rawout, serr) = proc.communicate() - if proc.returncode != 0: + if proc.returncode != 0 and len(serr) > 0: foutput = serr.decode("utf-8") else: foutput = rawout.decode("utf-8") @@ -203,7 +203,7 @@ def set_args(parser): help='Run tests only from the specified category, or if no category is specified, list known categories.') parser.add_argument('-f', '--file', type=str, help='Run tests from the specified file') - parser.add_argument('-l', '--list', type=str, nargs='?', const="", metavar='CATEGORY', + parser.add_argument('-l', '--list', type=str, nargs='?', const="++", metavar='CATEGORY', help='List all test cases, or those only within the specified category') parser.add_argument('-s', '--show', type=str, nargs=1, metavar='ID', dest='showID', help='Display the test case with specified id') @@ -357,10 +357,10 @@ def set_operation_mode(args): testcases = get_categorized_testlist(alltests, ucat) if args.list: - if (len(args.list) == 0): + if (args.list == "++"): list_test_cases(alltests) exit(0) - elif(len(args.list > 0)): + elif(len(args.list) > 0): if (args.list not in ucat): print("Unknown category " + args.list) print("Available categories:") |