diff options
author | Xiyu Yang <xiyuyang19@fudan.edu.cn> | 2020-04-23 06:54:19 +0200 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2020-04-23 09:10:05 +0200 |
commit | 59e1947ca09ebd1cae147c08c7c41f3141233c84 (patch) | |
tree | 065430ca3d376f3a861ea3da25792203ee56c8a2 /tools/wmi | |
parent | ALSA: usb-audio: Add connector notifier delegation (diff) | |
download | linux-59e1947ca09ebd1cae147c08c7c41f3141233c84.tar.xz linux-59e1947ca09ebd1cae147c08c7c41f3141233c84.zip |
ALSA: usb-audio: Fix usb audio refcnt leak when getting spdif
snd_microii_spdif_default_get() invokes snd_usb_lock_shutdown(), which
increases the refcount of the snd_usb_audio object "chip".
When snd_microii_spdif_default_get() returns, local variable "chip"
becomes invalid, so the refcount should be decreased to keep refcount
balanced.
The reference counting issue happens in several exception handling paths
of snd_microii_spdif_default_get(). When those error scenarios occur
such as usb_ifnum_to_if() returns NULL, the function forgets to decrease
the refcnt increased by snd_usb_lock_shutdown(), causing a refcnt leak.
Fix this issue by jumping to "end" label when those error scenarios
occur.
Fixes: 447d6275f0c2 ("ALSA: usb-audio: Add sanity checks for endpoint accesses")
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/1587617711-13200-1-git-send-email-xiyuyang19@fudan.edu.cn
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'tools/wmi')
0 files changed, 0 insertions, 0 deletions