diff options
| author | Ian Rogers <irogers@google.com> | 2023-09-14 04:22:04 +0200 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2023-09-18 00:51:35 +0200 |
| commit | d1bac78e26e513ce2cf1b47fcc667b33f51c6a36 (patch) | |
| tree | 788fd453a677e79ad04c38d104e1ada571e79ae2 /tools | |
| parent | perf trace: Avoid compile error wrt redefining bool (diff) | |
| download | linux-d1bac78e26e513ce2cf1b47fcc667b33f51c6a36.tar.xz linux-d1bac78e26e513ce2cf1b47fcc667b33f51c6a36.zip | |
perf jevents metric: Fix type of strcmp_cpuid_str
The parser wraps all strings as Events, so the input is an
Event. Using a string would be bad as functions like Simplify are
called on the arguments, which wouldn't be present on a string.
Fixes: 9d5da30e4ae9 ("perf jevents: Add a new expression builtin strcmp_cpuid_str()")
Signed-off-by: Ian Rogers <irogers@google.com>
Cc: James Clark <james.clark@arm.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: John Garry <john.g.garry@oracle.com>
Link: https://lore.kernel.org/r/20230914022204.1488383-1-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/pmu-events/metric.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/perf/pmu-events/metric.py b/tools/perf/pmu-events/metric.py index 0e9ec65d92ae..3e673f25d5fd 100644 --- a/tools/perf/pmu-events/metric.py +++ b/tools/perf/pmu-events/metric.py @@ -413,10 +413,10 @@ def has_event(event: Event) -> Function: # pylint: disable=invalid-name return Function('has_event', event) -def strcmp_cpuid_str(event: str) -> Function: +def strcmp_cpuid_str(cpuid: Event) -> Function: # pylint: disable=redefined-builtin # pylint: disable=invalid-name - return Function('strcmp_cpuid_str', event) + return Function('strcmp_cpuid_str', cpuid) class Metric: """An individual metric that will specifiable on the perf command line.""" |