summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorNamhyung Kim <namhyung@gmail.com>2011-12-12 16:16:52 +0100
committerArnaldo Carvalho de Melo <acme@redhat.com>2011-12-20 16:40:27 +0100
commitd74c896b7e3250a07f7d0315eecdd2ae1a7bc3c3 (patch)
treecb98caea083eb69494cfbd27e33702c87015cf30 /tools
parentperf symbols: Get rid of duplicated snprintf() (diff)
downloadlinux-d74c896b7e3250a07f7d0315eecdd2ae1a7bc3c3.tar.xz
linux-d74c896b7e3250a07f7d0315eecdd2ae1a7bc3c3.zip
perf symbols: Fix error path on symbol__init()
The order of freeing comm_list and dso_list should be reversed. Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1323703017-6060-4-git-send-email-namhyung@gmail.com Signed-off-by: Namhyung Kim <namhyung@gmail.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/perf/util/symbol.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index e54b13d4c357..215d50f2042e 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -2604,10 +2604,10 @@ int symbol__init(void)
symbol_conf.initialized = true;
return 0;
-out_free_dso_list:
- strlist__delete(symbol_conf.dso_list);
out_free_comm_list:
strlist__delete(symbol_conf.comm_list);
+out_free_dso_list:
+ strlist__delete(symbol_conf.dso_list);
return -1;
}