diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2022-12-20 01:47:00 +0100 |
|---|---|---|
| committer | Martin KaFai Lau <martin.lau@kernel.org> | 2022-12-21 00:58:35 +0100 |
| commit | 54c3f1a81421f85e60ae2eaae7be3727a09916ee (patch) | |
| tree | 278a501289a2323cb1e78f7a0b3b7201152bf33f /tools | |
| parent | bpf: Define sock security related BTF IDs under CONFIG_SECURITY_NETWORK (diff) | |
| download | linux-54c3f1a81421f85e60ae2eaae7be3727a09916ee.tar.xz linux-54c3f1a81421f85e60ae2eaae7be3727a09916ee.zip | |
bpf: pull before calling skb_postpull_rcsum()
Anand hit a BUG() when pulling off headers on egress to a SW tunnel.
We get to skb_checksum_help() with an invalid checksum offset
(commit d7ea0d9df2a6 ("net: remove two BUG() from skb_checksum_help()")
converted those BUGs to WARN_ONs()).
He points out oddness in how skb_postpull_rcsum() gets used.
Indeed looks like we should pull before "postpull", otherwise
the CHECKSUM_PARTIAL fixup from skb_postpull_rcsum() will not
be able to do its job:
if (skb->ip_summed == CHECKSUM_PARTIAL &&
skb_checksum_start_offset(skb) < 0)
skb->ip_summed = CHECKSUM_NONE;
Reported-by: Anand Parthasarathy <anpartha@meta.com>
Fixes: 6578171a7ff0 ("bpf: add bpf_skb_change_proto helper")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/r/20221220004701.402165-1-kuba@kernel.org
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions