summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorDave Marchevsky <davemarchevsky@fb.com>2023-04-24 22:43:21 +0200
committerAlexei Starovoitov <ast@kernel.org>2023-04-24 23:02:11 +0200
commit7deca5eae83389ca40ac1b1bde96e4af17cca84f (patch)
tree3177280c48b4814b2acc4f88eeccb40770e3c296 /tools
parentselftests/bpf: verifier/prevent_map_lookup converted to inline assembly (diff)
downloadlinux-7deca5eae83389ca40ac1b1bde96e4af17cca84f.tar.xz
linux-7deca5eae83389ca40ac1b1bde96e4af17cca84f.zip
bpf: Disable bpf_refcount_acquire kfunc calls until race conditions are fixed
As reported by Kumar in [0], the shared ownership implementation for BPF programs has some race conditions which need to be addressed before it can safely be used. This patch does so in a minimal way instead of ripping out shared ownership entirely, as proper fixes for the issues raised will follow ASAP, at which point this patch's commit can be reverted to re-enable shared ownership. The patch removes the ability to call bpf_refcount_acquire_impl from BPF programs. Programs can only bump refcount and obtain a new owning reference using this kfunc, so removing the ability to call it effectively disables shared ownership. Instead of changing success / failure expectations for bpf_refcount-related selftests, this patch just disables them from running for now. [0]: https://lore.kernel.org/bpf/d7hyspcow5wtjcmw4fugdgyp3fwhljwuscp3xyut5qnwivyeru@ysdq543otzv2/ Reported-by: Kumar Kartikeya Dwivedi <memxor@gmail.com> Signed-off-by: Dave Marchevsky <davemarchevsky@fb.com> Link: https://lore.kernel.org/r/20230424204321.2680232-1-davemarchevsky@fb.com Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'tools')
-rw-r--r--tools/testing/selftests/bpf/prog_tests/refcounted_kptr.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/tools/testing/selftests/bpf/prog_tests/refcounted_kptr.c b/tools/testing/selftests/bpf/prog_tests/refcounted_kptr.c
index 2ab23832062d..595cbf92bff5 100644
--- a/tools/testing/selftests/bpf/prog_tests/refcounted_kptr.c
+++ b/tools/testing/selftests/bpf/prog_tests/refcounted_kptr.c
@@ -9,10 +9,8 @@
void test_refcounted_kptr(void)
{
- RUN_TESTS(refcounted_kptr);
}
void test_refcounted_kptr_fail(void)
{
- RUN_TESTS(refcounted_kptr_fail);
}