diff options
author | Eric Paris <eparis@redhat.com> | 2010-07-28 16:18:38 +0200 |
---|---|---|
committer | Eric Paris <eparis@redhat.com> | 2010-07-28 16:18:51 +0200 |
commit | c1e5c954020e123d30b4abf4038ce501861bcf9f (patch) | |
tree | e8c9071ae4f37464e114fab79deea4716857f7ad /virt/kvm/assigned-dev.c | |
parent | fsnotify: store struct file not struct path (diff) | |
download | linux-c1e5c954020e123d30b4abf4038ce501861bcf9f.tar.xz linux-c1e5c954020e123d30b4abf4038ce501861bcf9f.zip |
vfs/fsnotify: fsnotify_close can delay the final work in fput
fanotify almost works like so:
user context calls fsnotify_* function with a struct file.
fsnotify takes a reference on the struct path
user context goes about it's buissiness
at some later point in time the fsnotify listener gets the struct path
fanotify listener calls dentry_open() to create a file which userspace can deal with
listener drops the reference on the struct path
at some later point the listener calls close() on it's new file
With the switch from struct path to struct file this presents a problem for
fput() and fsnotify_close(). fsnotify_close() is called when the filp has
already reached 0 and __fput() wants to do it's cleanup.
The solution presented here is a bit odd. If an event is created from a
struct file we take a reference on the file. We check however if the f_count
was already 0 and if so we take an EXTRA reference EVEN THOUGH IT WAS ZERO.
In __fput() (where we know the f_count hit 0 once) we check if the f_count is
non-zero and if so we drop that 'extra' ref and return without destroying the
file.
Signed-off-by: Eric Paris <eparis@redhat.com>
Diffstat (limited to 'virt/kvm/assigned-dev.c')
0 files changed, 0 insertions, 0 deletions