diff options
author | Jamal Hadi Salim <jhs@mojatatu.com> | 2013-12-23 14:02:11 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-12-27 18:50:00 +0100 |
commit | 1a29321ed045e3aad23c5f7b63036e465ee3093a (patch) | |
tree | 8d59b477b4b3fd575dcf33450cfbc7d5e9c3502b /virt/kvm/irq_comm.c | |
parent | rds: prevent dereference of a NULL device (diff) | |
download | linux-1a29321ed045e3aad23c5f7b63036e465ee3093a.tar.xz linux-1a29321ed045e3aad23c5f7b63036e465ee3093a.zip |
net_sched: act: Dont increment refcnt on replace
This is a bug fix. The existing code tries to kill many
birds with one stone: Handling binding of actions to
filters, new actions and replacing of action
attributes. A simple test case to illustrate:
XXXX
moja@fe1:~$ sudo tc actions add action drop index 12
moja@fe1:~$ actions get action gact index 12
action order 1: gact action drop
random type none pass val 0
index 12 ref 1 bind 0
moja@fe1:~$ sudo tc actions replace action ok index 12
moja@fe1:~$ actions get action gact index 12
action order 1: gact action drop
random type none pass val 0
index 12 ref 2 bind 0
XXXX
The above shows the refcounf being wrongly incremented on replace.
There are more complex scenarios with binding of actions to filters
that i am leaving out that didnt work as well...
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'virt/kvm/irq_comm.c')
0 files changed, 0 insertions, 0 deletions