diff options
author | Paul Moore <pmoore@redhat.com> | 2014-12-20 00:35:53 +0100 |
---|---|---|
committer | Paul Moore <pmoore@redhat.com> | 2014-12-20 00:35:53 +0100 |
commit | 3640dcfa4fd00cd91d88bb86250bdb496f7070c0 (patch) | |
tree | de75adc9ca42230ba0f8aeb4255c3f120acb51d8 /virt/kvm/irqchip.c | |
parent | Merge branch 'next' into upstream for v3.19 (diff) | |
download | linux-3640dcfa4fd00cd91d88bb86250bdb496f7070c0.tar.xz linux-3640dcfa4fd00cd91d88bb86250bdb496f7070c0.zip |
audit: don't attempt to lookup PIDs when changing PID filtering audit rules
Commit f1dc4867 ("audit: anchor all pid references in the initial pid
namespace") introduced a find_vpid() call when adding/removing audit
rules with PID/PPID filters; unfortunately this is problematic as
find_vpid() only works if there is a task with the associated PID
alive on the system. The following commands demonstrate a simple
reproducer.
# auditctl -D
# auditctl -l
# autrace /bin/true
# auditctl -l
This patch resolves the problem by simply using the PID provided by
the user without any additional validation, e.g. no calls to check to
see if the task/PID exists.
Cc: stable@vger.kernel.org # 3.15
Cc: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Paul Moore <pmoore@redhat.com>
Acked-by: Eric Paris <eparis@redhat.com>
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
Diffstat (limited to 'virt/kvm/irqchip.c')
0 files changed, 0 insertions, 0 deletions