diff options
| author | Mauricio Faria de Oliveira <mfo@canonical.com> | 2018-07-26 03:46:28 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2018-07-27 17:17:39 +0200 |
| commit | 14cb2c8a6c5dae57ee3e2da10fa3db2b9087e39e (patch) | |
| tree | 995d47f8d07db74f47d3ced70712a69044b49928 /virt | |
| parent | bcache: stop using the deprecated get_seconds() (diff) | |
| download | linux-14cb2c8a6c5dae57ee3e2da10fa3db2b9087e39e.tar.xz linux-14cb2c8a6c5dae57ee3e2da10fa3db2b9087e39e.zip | |
partitions/aix: fix usage of uninitialized lv_info and lvname structures
The if-block that sets a successful return value in aix_partition()
uses 'lvip[].pps_per_lv' and 'n[].name' potentially uninitialized.
For example, if 'numlvs' is zero or alloc_lvn() fails, neither is
initialized, but are used anyway if alloc_pvd() succeeds after it.
So, make the alloc_pvd() call conditional on their initialization.
This has been hit when attaching an apparently corrupted/stressed
AIX LUN, misleading the kernel to pr_warn() invalid data and hang.
[...] partition (null) (11 pp's found) is not contiguous
[...] partition (null) (2 pp's found) is not contiguous
[...] partition (null) (3 pp's found) is not contiguous
[...] partition (null) (64 pp's found) is not contiguous
Fixes: 6ceea22bbbc8 ("partitions: add aix lvm partition support files")
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'virt')
0 files changed, 0 insertions, 0 deletions