diff options
Diffstat (limited to 'drivers/video/sstfb.c')
| -rw-r--r-- | drivers/video/sstfb.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/drivers/video/sstfb.c b/drivers/video/sstfb.c index 99921df35474..c44de90ca12e 100644 --- a/drivers/video/sstfb.c +++ b/drivers/video/sstfb.c @@ -32,7 +32,7 @@ -TODO: at one time or another test that the mode is acceptable by the monitor -ASK: Can I choose different ordering for the color bitfields (rgba argb ...) - wich one should i use ? is there any preferred one ? It seems ARGB is + which one should i use ? is there any preferred one ? It seems ARGB is the one ... -TODO: in set_var check the validity of timings (hsync vsync)... -TODO: check and recheck the use of sst_wait_idle : we don't flush the fifo via @@ -1194,10 +1194,11 @@ static struct dac_switch dacs[] __devinitdata = { static int __devinit sst_detect_dactype(struct fb_info *info, struct sstfb_par *par) { int i, ret = 0; - - for (i=0; i<sizeof(dacs)/sizeof(dacs[0]); i++) { + + for (i = 0; i < ARRAY_SIZE(dacs); i++) { ret = dacs[i].detect(info); - if (ret) break; + if (ret) + break; } if (!ret) return 0; @@ -1604,8 +1605,8 @@ static int sstfb_dump_regs(struct fb_info *info) {FBZMODE,"fbzmode"}, }; - const int pci_s = sizeof(pci_regs)/sizeof(pci_regs[0]); - const int sst_s = sizeof(sst_regs)/sizeof(sst_regs[0]); + const int pci_s = ARRAY_SIZE(pci_regs); + const int sst_s = ARRAY_SIZE(sst_regs); struct sstfb_par *par = info->par; struct pci_dev *dev = par->dev; u32 pci_res[pci_s]; |