summaryrefslogtreecommitdiffstats
path: root/drivers/usb/serial (follow)
Commit message (Collapse)AuthorAgeFilesLines
* USB: serial: ir_usb: Clean up the worst of it, remove exciting 'crash on ↵Alan Cox2007-07-131-82/+60
| | | | | | | | | | | | | | | | | | | | open' feature - Drivers don't call ldisc termios methods. They certainly don't call them the way this one does - remove wrong call - The tty buffer code isn't designed to be abused from IRQ handlers and the new buffering removes the need for the uglies involved - fix them - Style - Remove incorrect baud and change handling for termios changes The driver now has some style, but not a lot - it goes insane if you have two dongles for example as it continues to use global variables for per dongle state. That bit isn't my problem. Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: belkin_sa: Various needed fixesAlan Cox2007-07-131-42/+27
| | | | | | | | | | | | | | | | | | Use the baud rate stuff from the kernel don't parse CBAUD directly Remove pointless and wrong 'no change' check Could do with some good testing as well but again better than adding && BROKEN (The use of BELKIN_SA_BAUD() might seem a bit odd but x/a = b and x/b = a (rounded for integers)). Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: ark3116.c: Mixed fixupsAlan Cox2007-07-131-38/+23
| | | | | | | | | | | | | | | | o Don't parse the cflag for baud rates, its not valid to do so any more and this driver got it wrong anyway o Don't do clever termios change checks in drivers and get them wrong (arguably we should do some smart ones in the tty core but stty to change nothing is *not* a common or critical path I don't have the hardware so if you can test this carefully please do. I thought fixing it up this far was better than marking it and other bits of USB serial && BROKEN Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: sierra: cleanup the startup and shutdown pathGreg Kroah-Hartman2007-07-131-89/+41
| | | | | | | | | | | | | | | | | This removes the ugly code that was copied from the keyspan driver and allocates the in urbs in a much shorter code path that can be understood easier. Also turned off the interrupt urb when no port was open as it's not nice to keep the bus busy for no good reason at all (this should be a power savings.) All in all, this saved over 40 lines of code and cleaned things up better. Cc: Kevin Lloyd <linux@sierrawireless.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: sierra: remove incorrect usage of the urb status fieldGreg Kroah-Hartman2007-07-131-114/+107
| | | | | | | | | | | | | | | You can't rely on the fact that the status really is correct like it was. Also simplified the write path and now we allocate the urb and data on the fly, instead of trying to do that really odd timeout check which I am guessing doesn't really work properly. This should speed up the device by keeping the hardware queue full easier. As a benefit, this reduces the size of the driver. Cc: Kevin Lloyd <linux@sierrawireless.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: whiteheat: clean up urb->status usageGreg Kroah-Hartman2007-07-131-9/+16
| | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: visor: clean up urb->status usageGreg Kroah-Hartman2007-07-131-8/+12
| | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: ti_usb_3410_5052: clean up urb->status usageGreg Kroah-Hartman2007-07-131-19/+27
| | | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Al Borchers <alborchers@steinerpoint.com> Cc: Peter Berger <pberger@brimson.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: sierra: clean up urb->status usageGreg Kroah-Hartman2007-07-131-6/+8
| | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Kevin Lloyd <linux@sierrawireless.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: safe_serial: clean up urb->status usageGreg Kroah-Hartman2007-07-131-2/+4
| | | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Stuart Lynne <sl@lineo.com> Cc: Tom Rushworth <tbr@lineo.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: pl2303: clean up urb->status usageGreg Kroah-Hartman2007-07-131-20/+22
| | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: oti6858: clean up urb->status usageGreg Kroah-Hartman2007-07-131-17/+18
| | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: option: clean up urb->status usageGreg Kroah-Hartman2007-07-131-6/+8
| | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Matthias Urlichs <smurf@smurf.noris.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: omninet: clean up urb->status usageGreg Kroah-Hartman2007-07-131-5/+8
| | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: navman: clean up urb->status usageGreg Kroah-Hartman2007-07-131-3/+4
| | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: mos7840: clean up urb->status usageGreg Kroah-Hartman2007-07-131-15/+19
| | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Paul Schroeder <pschroeder@uplogix.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: mos7720: clean up urb->status usageGreg Kroah-Hartman2007-07-131-12/+15
| | | | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: VijayaKumar G.N. <vijaykumar@aspirecom.net> Cc: AjayKumar <ajay@aspirecom.net> Cc: Gurudeva N. <gurudev@aspirecom.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: mct_u232: clean up urb->status usageGreg Kroah-Hartman2007-07-131-7/+10
| | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Wolfgang Grandegger <wolfgang@ces.ch> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: kobil_sct: clean up urb->status usageGreg Kroah-Hartman2007-07-131-12/+14
| | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Thomas Wahrenbruch <linuxusb@kobil.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: kl5kusb105: clean up urb->status usageGreg Kroah-Hartman2007-07-131-10/+12
| | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Utz-Uwe Haus <haus@uuhaus.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: keyspan_pda: clean up urb->status usageGreg Kroah-Hartman2007-07-131-7/+10
| | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: keyspan: clean up urb->status usageGreg Kroah-Hartman2007-07-131-20/+30
| | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: ir-usb: clean up urb->status usageGreg Kroah-Hartman2007-07-131-5/+7
| | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Gary Brubaker <xavyer@ix.netcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: ipw: clean up urb->status usageGreg Kroah-Hartman2007-07-131-4/+8
| | | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Roelf Diedericks <roelfd@inet.co.za> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: ipaq: clean up urb->status usageGreg Kroah-Hartman2007-07-131-5/+9
| | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Ganesh Varadarajan <ganesh@veritas.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: io_ti: clean up urb->status usageGreg Kroah-Hartman2007-07-131-20/+27
| | | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Al Borchers <alborchers@steinerpoint.com> Cc: Peter Berger <pberger@brimson.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: io_edgeport: clean up urb->status usageGreg Kroah-Hartman2007-07-131-11/+20
| | | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Al Borchers <alborchers@steinerpoint.com> Cc: Peter Berger <pberger@brimson.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: generic: clean up urb->status usageGreg Kroah-Hartman2007-07-131-4/+8
| | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: garmin_gps: clean up urb->status usageGreg Kroah-Hartman2007-07-131-22/+25
| | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Hermann Kneissel <herkne@users.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: ftdi_sio: clean up urb->status usageGreg Kroah-Hartman2007-07-131-4/+7
| | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Kuba Ober <kuba@mareimbrium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: empeg: clean up urb->status usageGreg Kroah-Hartman2007-07-131-5/+9
| | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Gary Brubaker <xavyer@ix.netcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: digi_acceleport: clean up urb->status usageGreg Kroah-Hartman2007-07-131-17/+26
| | | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Peter Berger <pberger@brimson.com> Cc: Al Borchers <borchers@steinerpoint.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: cypress_m8: clean up urb->status usageGreg Kroah-Hartman2007-07-131-7/+11
| | | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: Lonnie Mendez <dignome@gmail.com> Cc: Neil Whelchel <koyama@firstlight.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: cyberjack: clean up urb->status usageGreg Kroah-Hartman2007-07-131-6/+11
| | | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Cc: <support@reiner-sct.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: belkin_sa: clean up urb->status usageGreg Kroah-Hartman2007-07-131-3/+6
| | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: airprime: clean up urb->status usageGreg Kroah-Hartman2007-07-131-4/+6
| | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: serial: aircable: clean up urb->status usageGreg Kroah-Hartman2007-07-131-7/+9
| | | | | | | | | | This done in anticipation of removal of urb->status, which will make that patch easier to review and apply in the future. Cc: <linux-usb-devel@lists.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: fix up license wording on some of my usb-serial driversGreg Kroah-Hartman2007-07-133-11/+10
| | | | | | | Also update the copyright date on the pl2303 driver, as it was out of date. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* synchronization in usb_serial_putBenny Halevy2007-07-131-2/+2
| | | | | | | | | | | | | | | | | | | I think there is a race between usb_serial_put() and usb_serial_get_by_index() (and get_free_serial()) with regards to handling the serial port refcount. usb_serial_get_by_index() gets a reference on the serial port under table_lock while return_serial releases all the returned ports from the table under the same lock. However, the table_lock is not taken around the call to kref_put, theoretically allowing to sneak in and grab a reference after kref_put has already determined that the reference count is zero (and before calling destroy_serial) causing use after free. Signed-off-by: Benny Halevy <bhalevy@ns1.bhalevy.com> Cc: Oliver Neukum <oneukum@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: io_ti: sleep with spinlock held detected by automatic toolOliver Neukum2007-07-131-1/+1
| | | | | | | | this fixes the sleep found with the automatic tool. Signed-off-by: Oliver Neukum <oneukum@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: option: fix usage of urb->status abuseAlan Stern2007-07-131-3/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Might fix bug 8561 On Mon, 4 Jun 2007, Paulo Pereira wrote: > The patch that you send is not resolving the problem... :( > I stil have Kernel panic after 45/60 min of work with Ktorrent/Amule... > > The Drump is: > > Call Trace: > [<c055fb36>] usb_hcd_submit+0xb1/0x763 > [<f9276488>] ipt_do_table+0x2c7/0x2ef [ip_tables] > [<f929a6d7>] nf_ct_deliver_cached_events+0x41/0x96 [nf_conntrak] > [<f9288254>] ipv4_confirm+0x36/0c3b [nf_conntrack_ipv4] > [<c05ce7c2>] tcp_v4_rcv+0x827/0x899 > [<c05afcc0>] nf_hook_slow+0x4d/0xb5 > [<c042826f>] irq_enter+0x19/0x23 > [<c042826f>] irq_enter+0x19/0x23 > [<c040794c>] do_IRQ+0xbd/0xd1 > [<f90893c9>] option_write+0xa7/0xef [option] Okay, from this it looks like there's a problem in the option.c serial driver. Glancing at the code, it's obvious why: The thing totally abuses the USB API. Try applying this patch; it should help. From: Alan Stern <stern@rowland.harvard.edu> Cc: Paulo Pereira <pfmp.404@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: digi_acceleport further buffer clean upAl Borchers2007-07-131-6/+0
| | | | | | | | | | Some further cleanup after Oliver's patch to update the tty buffering. The input buffer is not used at all anymore, so I removed it. Signed-off-by: Al Borchers <alborchers@steinerpoint.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: whiteheat driver updateOliver Neukum2007-07-131-40/+52
| | | | | | | | | | | | this is an update of the whiteheat driver. It fixes: - switch from spinlocks to mutexes to prevent sleeping with a spinlock held - locking to stop races with disconnect - error handling for commands that time out Signed-off-by: Oliver Neukum <oneukum@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: flow control fix for pl2303t.sefzick2007-07-131-0/+7
| | | | | | | | | | in order to be able to switch back to 'flow-control none' after having activated 'flow-control rts/cts', I made a small change to 'pl2303.c'. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: generic usb serial to new buffering schemeOliver Neukum2007-07-131-35/+34
| | | | | | | | the generic driver also had its own buffering. Signed-off-by: Oliver Neukum <oneukum@suse.de_ Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: Digi AccelePort adapted to new tty bufferingOliver Neukum2007-07-131-39/+13
| | | | | | | | | | this fixes the flushing trouble due to its own buffering for this driver. Signed-off-by: Oliver Neukum <oneukum@suse.de> Cc: Al Borchers <alborchers@steinerpoint.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: visor driver adapted to new tty bufferingOliver Neukum2007-07-131-12/+18
| | | | | | | | | | | the new tty buffering code allows usb drivers to stop private buffering. In fact we must do so to allow flushing to work correctly. This does so for the visor driver. Signed-off-by: Oliver Neukum <oneukum@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: ftdi_sio.c: Allow setting latency timer on FT232RLStepan Moskovchenko2007-07-131-1/+3
| | | | | | | | | | | | | The new FT232RL allows setting and getting the value of the latency timer, like on the FT232BM. However, the driver will not create the sysfs entries for the RL without this one-line patch. I have tested it on two systems with successful results. From: Stepan Moskovchenko <stevenm86@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: RTS/CTS handshaking support, DTR fixes for MCT U232 serial adapterDave Platt2007-07-132-41/+106
| | | | | | | | | | | | Improvements and fixes to the MCT U232 USB/serial interface driver. Implement RTS/CTS hardware flow control. Implement HUPCL. Bring handling of DTR and RTS into conformance with other Linux serial port drivers - assert both signals when opening device, even if "crtscts" is not currently selected. Signed-off-by: Dave Platt <dplatt@radagast.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* USB: io_ti: Digi EdgePort update for new devicesMartin K. Petersen2007-07-133-732/+807
| | | | | | | | | | | This patch adds support for the most recent Digi EdgePort USB serial devices. Signed-off-by: Martin K. Petersen <mkp@mkp.net> Signed-off-by: Mike Swift <mikes@digi.com> Signed-off-by: Jeremy McBane <jmcbane@digi.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-02 03:44:02 +0100