From 60aece416483fdf7e51728a3518438e0458bdabb Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Tue, 27 Aug 2019 08:44:20 +0200 Subject: powerpc/82xx: Delete an unnecessary of_node_put() call in pq2ads_pci_init_irq() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A null pointer would be passed to a call of the function “of_node_put” immediately after a call of the function “of_find_compatible_node” failed at one place. Remove this superfluous function call. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/9c060a41-438b-6fb8-d549-37c72fae4898@web.de --- arch/powerpc/platforms/82xx/pq2ads-pci-pic.c | 1 - 1 file changed, 1 deletion(-) (limited to 'arch/powerpc/platforms/82xx') diff --git a/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c b/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c index 096cc0d59fd8..6cc054db7043 100644 --- a/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c +++ b/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c @@ -123,7 +123,6 @@ int __init pq2ads_pci_init_irq(void) np = of_find_compatible_node(NULL, NULL, "fsl,pq2ads-pci-pic"); if (!np) { printk(KERN_ERR "No pci pic node in device tree.\n"); - of_node_put(np); goto out; } -- cgit v1.2.3