From 00cf99ee00c9f1241359c8ee5ca9230318e27a57 Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Tue, 25 Jun 2013 10:09:57 +0800 Subject: pwm: renesas-tpu: fix return value check in tpu_probe() In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun Reviewed-by: Axel Lin Acked-by: Laurent Pinchart Signed-off-by: Thierry Reding --- drivers/pwm/pwm-renesas-tpu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'drivers/pwm/pwm-renesas-tpu.c') diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c index 96e0cc488a4e..03c1aa3c48a2 100644 --- a/drivers/pwm/pwm-renesas-tpu.c +++ b/drivers/pwm/pwm-renesas-tpu.c @@ -410,10 +410,8 @@ static int tpu_probe(struct platform_device *pdev) } tpu->base = devm_ioremap_resource(&pdev->dev, res); - if (tpu->base == NULL) { - dev_err(&pdev->dev, "failed to remap I/O memory\n"); - return -ENXIO; - } + if (IS_ERR(tpu->base)) + return PTR_ERR(tpu->base); tpu->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(tpu->clk)) { -- cgit v1.2.3