From 6787341a0f15cc79b9dd4f1341df2f5f3ad3bff1 Mon Sep 17 00:00:00 2001 From: Miklos Szeredi Date: Thu, 27 Jul 2017 21:54:05 +0200 Subject: ovl: check snprintf return Signed-off-by: Miklos Szeredi --- fs/overlayfs/inode.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'fs') diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c index 5bc71642b226..aecaadc8f9e7 100644 --- a/fs/overlayfs/inode.c +++ b/fs/overlayfs/inode.c @@ -498,6 +498,9 @@ static int ovl_set_nlink_common(struct dentry *dentry, len = snprintf(buf, sizeof(buf), format, (int) (inode->i_nlink - realinode->i_nlink)); + if (WARN_ON(len >= sizeof(buf))) + return -EIO; + return ovl_do_setxattr(ovl_dentry_upper(dentry), OVL_XATTR_NLINK, buf, len, 0); } -- cgit v1.2.3