From f77c6e9c8f9c444cd44423df0c2708e86a06a696 Mon Sep 17 00:00:00 2001 From: Ramkumar Ramachandra Date: Mon, 30 Dec 2013 13:04:18 +0530 Subject: perf tools: Generalize percent_color_snprintf() Make percent_color_snprintf() handle negative values correctly. Signed-off-by: Ramkumar Ramachandra Acked-by: Jiri Olsa Cc: Jiri Olsa Link: http://lkml.kernel.org/r/1388388861-7931-2-git-send-email-artagnon@gmail.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/color.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'tools') diff --git a/tools/perf/util/color.c b/tools/perf/util/color.c index 66e44a5019d5..8cda46c43e74 100644 --- a/tools/perf/util/color.c +++ b/tools/perf/util/color.c @@ -1,6 +1,7 @@ #include #include "cache.h" #include "color.h" +#include int perf_use_color_default = -1; @@ -298,10 +299,10 @@ const char *get_percent_color(double percent) * entries in green - and keep the low overhead places * normal: */ - if (percent >= MIN_RED) + if (fabs(percent) >= MIN_RED) color = PERF_COLOR_RED; else { - if (percent > MIN_GREEN) + if (fabs(percent) > MIN_GREEN) color = PERF_COLOR_GREEN; } return color; -- cgit v1.2.3