summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNigel Croxon <ncroxon@redhat.com>2024-07-02 15:49:13 +0200
committerMariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>2024-07-03 12:56:08 +0200
commit0244bac0a828e69aef36404437cac4ff148eaea0 (patch)
tree722faa3408b1ebe40a1ed249712831a1d9e6a09f
parentconfig.c: Fix memory leak in load_containers() (diff)
downloadmdadm-0244bac0a828e69aef36404437cac4ff148eaea0.tar.xz
mdadm-0244bac0a828e69aef36404437cac4ff148eaea0.zip
mdadm: Build.c fix coverity issues
Event leaked_handle: Handle variable "bitmap_fd" going out of scope leaks the handle. Signed-off-by: Nigel Croxon <ncroxon@redhat.com>
Diffstat (limited to '')
-rw-r--r--Build.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/Build.c b/Build.c
index 1be90e41..052b1bc2 100644
--- a/Build.c
+++ b/Build.c
@@ -168,13 +168,13 @@ int Build(struct mddev_ident *ident, struct mddev_dev *devlist, struct shape *s,
goto abort;
}
}
- if (bitmap_fd >= 0) {
- if (ioctl(mdfd, SET_BITMAP_FILE, bitmap_fd) < 0) {
- pr_err("Cannot set bitmap file for %s: %s\n", chosen_name,
- strerror(errno));
- goto abort;
- }
+ if (ioctl(mdfd, SET_BITMAP_FILE, bitmap_fd) < 0) {
+ pr_err("Cannot set bitmap file for %s: %s\n", chosen_name,
+ strerror(errno));
+ close(bitmap_fd);
+ goto abort;
}
+ close(bitmap_fd);
}
if (ioctl(mdfd, RUN_ARRAY, &param)) {
pr_err("RUN_ARRAY failed: %s\n", strerror(errno));