diff options
| author | Xiao Ni <xni@redhat.com> | 2024-10-18 10:48:16 +0200 |
|---|---|---|
| committer | Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> | 2024-10-18 14:50:01 +0200 |
| commit | c6ca5b31e18f92490e639de0e5eae88985628633 (patch) | |
| tree | 26c8f9ff81b369f630aa861ba729f48cbba3e6db | |
| parent | util: use only /dev directory in open_dev() (diff) | |
| download | mdadm-c6ca5b31e18f92490e639de0e5eae88985628633.tar.xz mdadm-c6ca5b31e18f92490e639de0e5eae88985628633.zip | |
mdadm/Manage: Clear superblock if adding new device fails
The superblock is kept if adding new device fails. It should clear the
superblock if it fails to add a new disk.
Signed-off-by: Xiao Ni <xni@redhat.com>
Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
| -rw-r--r-- | Manage.c | 4 |
1 files changed, 4 insertions, 0 deletions
@@ -793,6 +793,7 @@ int Manage_add(int fd, int tfd, struct mddev_dev *dv, int j; mdu_disk_info_t disc; struct map_ent *map = NULL; + bool add_new_super = false; if (!get_dev_size(tfd, dv->devname, &ldsize)) { if (dv->disposition == 'M') @@ -1011,6 +1012,7 @@ int Manage_add(int fd, int tfd, struct mddev_dev *dv, goto unlock; if (tst->ss->write_init_super(tst)) goto unlock; + add_new_super = true; } else if (dv->disposition == 'A') { /* this had better be raid1. * As we are "--re-add"ing we must find a spare slot @@ -1078,6 +1080,8 @@ int Manage_add(int fd, int tfd, struct mddev_dev *dv, map_unlock(&map); return 1; unlock: + if (add_new_super) + Kill(dv->devname, tst, 0, -1, 0); map_unlock(&map); return -1; } |