diff options
author | Zhao Heming <heming.zhao@suse.com> | 2021-02-03 01:22:51 +0100 |
---|---|---|
committer | Jes Sorensen <jsorensen@fb.com> | 2021-03-03 15:30:14 +0100 |
commit | f7a6246bab1541d7208a5f0f9f0c6cac114e38da (patch) | |
tree | 7765126311e90745fa7acd25e5797e5bf31d4413 | |
parent | super1: fix Floating point exception (diff) | |
download | mdadm-f7a6246bab1541d7208a5f0f9f0c6cac114e38da.tar.xz mdadm-f7a6246bab1541d7208a5f0f9f0c6cac114e38da.zip |
super1.c: avoid useless sync when bitmap switches from clustered to none
With kernel commit 480523feae58 ("md: only call set_in_sync() when it
is expected to succeed."), mddev->in_sync in clustered array is always
zero. It makes metadata resync_offset to always zero.
When assembling a clusterd array with "-U no-bitmap" option, kernel
md layer "mddev->resync_offset == 0" and "mddev->bitmap == NULL" will
trigger raid1 do sync on every bitmap chunk. the sync action is useless,
we should avoid it.
Related kernel flow:
```
md_do_sync
mddev->pers->sync_request
raid1_sync_request
md_bitmap_start_sync(mddev->bitmap, sector_nr, &sync_blocks, 1)
__bitmap_start_sync(bitmap, offset,&blocks1, degraded)
if (bitmap == NULL) {/* FIXME or bitmap set as 'failed' */
*blocks = 1024;
return 1; /* always resync if no bitmap */
}
```
Reprodusible steps:
```
node1 # mdadm -C /dev/md0 -b clustered -e 1.2 -n 2 -l mirror /dev/sd{a,b}
node1 # mdadm -Ss
(in another shell, executing & watching: watch -n 1 'cat /proc/mdstat')
node1 # mdadm -A -U no-bitmap /dev/md0 /dev/sd{a,b}
```
Signed-off-by: Zhao Heming <heming.zhao@suse.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
-rw-r--r-- | super1.c | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -1346,6 +1346,8 @@ static int update_super1(struct supertype *st, struct mdinfo *info, memcpy(bms->uuid, sb->set_uuid, 16); } else if (strcmp(update, "no-bitmap") == 0) { sb->feature_map &= ~__cpu_to_le32(MD_FEATURE_BITMAP_OFFSET); + if (bms->version == BITMAP_MAJOR_CLUSTERED && !IsBitmapDirty(devname)) + sb->resync_offset = MaxSector; } else if (strcmp(update, "bbl") == 0) { /* only possible if there is room after the bitmap, or if * there is no bitmap |