diff options
author | Xiao Ni <xni@redhat.com> | 2020-07-27 03:14:20 +0200 |
---|---|---|
committer | Jes Sorensen <jsorensen@fb.com> | 2020-08-07 15:46:03 +0200 |
commit | 138a9e9bbe2622eafc90c976b82f3d84895dbebd (patch) | |
tree | 9e908ab634b25c155b5d379aa6c9216cb6bb12e8 /mdadm.c | |
parent | mdadm/Grow: prevent md's fd from being occupied during delayed time (diff) | |
download | mdadm-138a9e9bbe2622eafc90c976b82f3d84895dbebd.tar.xz mdadm-138a9e9bbe2622eafc90c976b82f3d84895dbebd.zip |
Specify nodes number when updating cluster nodes
Now it allows updating cluster nodes without specify --nodes. It can write superblock
with zero nodes. It can break the current cluster. Add this check to avoid this problem.
v2: It needs check c.update first to avoid NULL pointer reference
v3: Wol points the typo error
Signed-off-by: Xiao Ni <xni@redhat.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
Diffstat (limited to 'mdadm.c')
-rw-r--r-- | mdadm.c | 5 |
1 files changed, 5 insertions, 0 deletions
@@ -1433,6 +1433,11 @@ int main(int argc, char *argv[]) } } + if (c.update && strcmp(c.update, "nodes") == 0 && c.nodes == 0) { + pr_err("Please specify nodes number with --nodes\n"); + exit(1); + } + if (c.backup_file && data_offset != INVALID_SECTORS) { pr_err("--backup-file and --data-offset are incompatible\n"); exit(2); |