diff options
| author | Guoqing Jiang <guoqing.jiang@cloud.ionos.com> | 2020-05-18 23:53:36 +0200 |
|---|---|---|
| committer | Jes Sorensen <jsorensen@fb.com> | 2020-05-19 02:24:29 +0200 |
| commit | d92cee7b374db9944b63bdd6c1784a2dd90ee9ca (patch) | |
| tree | ab4562313e4c6d67f23a1b06d317c5c64f0694cb /restripe.c | |
| parent | Include count for \0 character when using strncpy to implement strdup. (diff) | |
| download | mdadm-d92cee7b374db9944b63bdd6c1784a2dd90ee9ca.tar.xz mdadm-d92cee7b374db9944b63bdd6c1784a2dd90ee9ca.zip | |
restripe: fix ignoring return value of ‘read’ and lseek
Got below error when run "make everything".
restripe.c: In function ‘test_stripes’:
restripe.c:870:4: error: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Werror=unused-result]
read(source[i], stripes[i], chunk_size);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fix it by check the return value of ‘read’, and free memory
in the failure case.
And check the return value of lseek as well per Jes's comment.
Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
Diffstat (limited to 'restripe.c')
| -rw-r--r-- | restripe.c | 12 |
1 files changed, 10 insertions, 2 deletions
@@ -866,8 +866,16 @@ int test_stripes(int *source, unsigned long long *offsets, int disk; for (i = 0 ; i < raid_disks ; i++) { - lseek64(source[i], offsets[i]+start, 0); - read(source[i], stripes[i], chunk_size); + if ((lseek64(source[i], offsets[i]+start, 0) < 0) || + (read(source[i], stripes[i], chunk_size) != + chunk_size)) { + free(q); + free(p); + free(blocks); + free(stripes); + free(stripe_buf); + return -1; + } } for (i = 0 ; i < data_disks ; i++) { int disk = geo_map(i, start/chunk_size, raid_disks, |