summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDr. David von Oheimb <David.von.Oheimb@siemens.com>2021-04-29 08:05:10 +0200
committerDr. David von Oheimb <dev@ddvo.net>2021-05-20 16:29:13 +0200
commit9ad9002dd5f705d528ae20acb0e1b53767cde3dd (patch)
tree96ea09eae5cda2d700d4188304a49cbfec612e38
parentcheck-format.pl: Report needless intermediate multiple SPC only on -e or --ex... (diff)
downloadopenssl-9ad9002dd5f705d528ae20acb0e1b53767cde3dd.tar.xz
openssl-9ad9002dd5f705d528ae20acb0e1b53767cde3dd.zip
check-format.pl: Fix false positive "no SPC before binary '*'" for '!*'
Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from https://github.com/openssl/openssl/pull/15077)
-rwxr-xr-xutil/check-format.pl2
1 files changed, 1 insertions, 1 deletions
diff --git a/util/check-format.pl b/util/check-format.pl
index 5c637f9333..734022c540 100755
--- a/util/check-format.pl
+++ b/util/check-format.pl
@@ -683,7 +683,7 @@ while (<>) { # loop over all lines of all input files
# TODO ternary ':' without preceding SPC, while allowing no SPC before ':' after 'case'
report("no SPC before binary '$1'") if $intra_line =~ m/[^\s{()\[]([+\-])/;# +/- without preceding space or {()[
# or ')' (which is used f type casts)
- report("no SPC before binary '$1'") if $intra_line =~ m/[^\s{()\[*]([*])/; # '*' without preceding space or {()[*
+ report("no SPC before binary '$1'") if $intra_line =~ m/[^\s{()\[*!]([*])/; # '*' without preceding space or {()[*!
report("no SPC before binary '$1'") if $intra_line =~ m/[^\s{()\[]([&])/; # '&' without preceding space or {()[
report("no SPC after ternary '$1'") if $intra_line =~ m/(:)[^\s\d]/; # ':' without following space or digit
report("no SPC after '$1'") if $intra_line =~ m/([,;=|\/%<>^\?])\S/; # ,;=|/%<>^? without following space