summaryrefslogtreecommitdiffstats
path: root/crypto/ct
diff options
context:
space:
mode:
authorRob Percival <robpercival@google.com>2016-08-06 03:27:12 +0200
committerRich Salz <rsalz@openssl.org>2016-08-06 03:34:59 +0200
commita6f5d614c53aaa58595af4998228e82404132739 (patch)
tree48c1f00c3f6553f216ef09fecc1b5f95e6071e7b /crypto/ct
parentfixing too optimistic typo-fix (diff)
downloadopenssl-a6f5d614c53aaa58595af4998228e82404132739.tar.xz
openssl-a6f5d614c53aaa58595af4998228e82404132739.zip
Mkae CT_log_new_from_base64 always return 0 on failure
In one failure case, it used to return -1. That failure case (CTLOG_new() returning NULL) was not usefully distinct from all of the other failure cases. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/1407)
Diffstat (limited to 'crypto/ct')
-rw-r--r--crypto/ct/ct_b64.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/ct/ct_b64.c b/crypto/ct/ct_b64.c
index 80bd45e2d9..d13d8f2af2 100644
--- a/crypto/ct/ct_b64.c
+++ b/crypto/ct/ct_b64.c
@@ -149,7 +149,7 @@ int CTLOG_new_from_base64(CTLOG **ct_log, const char *pkey_base64, const char *n
*ct_log = CTLOG_new(pkey, name);
if (*ct_log == NULL) {
EVP_PKEY_free(pkey);
- return -1;
+ return 0;
}
return 1;