diff options
| author | Richard Levitte <levitte@openssl.org> | 2009-01-03 10:25:32 +0100 |
|---|---|---|
| committer | Richard Levitte <levitte@openssl.org> | 2009-01-03 10:25:32 +0100 |
| commit | 792bbc2374b4ea2d1b722ecdc1ff74417219b3ae (patch) | |
| tree | e55936a4ffa8fba1bbd810ede8a5b356e5613245 /crypto/rand/md_rand.c | |
| parent | srvr_ecdh cannot be NULL at this point (Coverity ID 232). (diff) | |
| download | openssl-792bbc2374b4ea2d1b722ecdc1ff74417219b3ae.tar.xz openssl-792bbc2374b4ea2d1b722ecdc1ff74417219b3ae.zip | |
VMS stuff I forgot...
Diffstat (limited to 'crypto/rand/md_rand.c')
| -rw-r--r-- | crypto/rand/md_rand.c | 20 |
1 files changed, 17 insertions, 3 deletions
diff --git a/crypto/rand/md_rand.c b/crypto/rand/md_rand.c index 810b4c2d4a..88088ce73c 100644 --- a/crypto/rand/md_rand.c +++ b/crypto/rand/md_rand.c @@ -272,8 +272,16 @@ static void ssleay_rand_add(const void *buf, int num, double add) } else MD_Update(&m,&(state[st_idx]),j); - + + /* DO NOT REMOVE THE FOLLOWING CALL TO MD_Update()! */ MD_Update(&m,buf,j); + /* We know that line may cause programs such as + purify and valgrind to complain about use of + uninitialized data. The problem is not, it's + with the caller. Removing that line will make + sure you get really bad randomness and thereby + other problems such as very insecure keys. */ + MD_Update(&m,(unsigned char *)&(md_c[0]),sizeof(md_c)); MD_Final(&m,local_md); md_c[1]++; @@ -466,9 +474,15 @@ static int ssleay_rand_bytes(unsigned char *buf, int num) #endif MD_Update(&m,local_md,MD_DIGEST_LENGTH); MD_Update(&m,(unsigned char *)&(md_c[0]),sizeof(md_c)); -#ifndef PURIFY - MD_Update(&m,buf,j); /* purify complains */ + +#ifndef PURIFY /* purify complains */ + /* DO NOT REMOVE THE FOLLOWING CALL TO MD_Update()! */ + MD_Update(&m,buf,j); + /* We know that line may cause programs such as + purify and valgrind to complain about use of + uninitialized data. */ #endif + k=(st_idx+MD_DIGEST_LENGTH/2)-st_num; if (k > 0) { |