summaryrefslogtreecommitdiffstats
path: root/crypto/ui/ui_lib.c
diff options
context:
space:
mode:
authorRichard Levitte <levitte@openssl.org>2017-07-05 10:26:25 +0200
committerRichard Levitte <levitte@openssl.org>2017-07-05 11:15:37 +0200
commitb96dba9e5ec7afc355be1eab915f69c8c0d51741 (patch)
tree9e1a038d3dfcd503f3dd38a159c3f03516316f24 /crypto/ui/ui_lib.c
parentAvoid possible memleak in X509_policy_check() (diff)
downloadopenssl-b96dba9e5ec7afc355be1eab915f69c8c0d51741.tar.xz
openssl-b96dba9e5ec7afc355be1eab915f69c8c0d51741.zip
Fix small UI issues
- in EVP_read_pw_string_min(), the return value from UI_add_* wasn't properly checked - in UI_process(), |state| was never made NULL, which means an error when closing the session wouldn't be accurately reported. Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/3849)
Diffstat (limited to 'crypto/ui/ui_lib.c')
-rw-r--r--crypto/ui/ui_lib.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/crypto/ui/ui_lib.c b/crypto/ui/ui_lib.c
index 4469a436c2..5b3eaff121 100644
--- a/crypto/ui/ui_lib.c
+++ b/crypto/ui/ui_lib.c
@@ -515,6 +515,8 @@ int UI_process(UI *ui)
}
}
}
+
+ state = NULL;
err:
if (ui->meth->ui_close_session != NULL
&& ui->meth->ui_close_session(ui) <= 0) {