diff options
| author | Richard Levitte <levitte@openssl.org> | 2021-01-26 06:48:11 +0100 |
|---|---|---|
| committer | Richard Levitte <levitte@openssl.org> | 2021-01-27 12:06:29 +0100 |
| commit | eeb09f1bd7754e85e832853f46a726c761c93df1 (patch) | |
| tree | 4b3dd5083033b6d07a7bb9b15e837081ff7590ba /doc/man3 | |
| parent | TLS client: allow cert verify callback return -1 for SSL_ERROR_WANT_RETRY_VERIFY (diff) | |
| download | openssl-eeb09f1bd7754e85e832853f46a726c761c93df1.tar.xz openssl-eeb09f1bd7754e85e832853f46a726c761c93df1.zip | |
Fix OSSL_PARAM_allocate_from_text() for EBCDIC
OSSL_PARAM_allocate_from_text() converted text values to UTF-8
OSSL_PARAMs with a simple strncpy(). However, if the text is EBCDIC,
that won't become UTF-8. Therefore, it's made to convert from EBCDIC
to ASCII on platforms where the native character encoding is the
former.
One might argue that the conversion should be the responsibility of
the application. However, this is a helper function, and the calling
application can't easily know what sort of OSSL_PARAM the input values
are going to be used for.
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/13961)
Diffstat (limited to 'doc/man3')
| -rw-r--r-- | doc/man3/OSSL_PARAM_allocate_from_text.pod | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/doc/man3/OSSL_PARAM_allocate_from_text.pod b/doc/man3/OSSL_PARAM_allocate_from_text.pod index 011685c8c8..6522e3b135 100644 --- a/doc/man3/OSSL_PARAM_allocate_from_text.pod +++ b/doc/man3/OSSL_PARAM_allocate_from_text.pod @@ -73,8 +73,10 @@ considers that an error. If I<key> started with "hex", OSSL_PARAM_allocate_from_text() considers that an error. -Otherwise, I<value> is considered a C string and is copied with no -further checks to the I<< to->data >> storage. +Otherwise, I<value> is considered a C string and is copied to the +I<< to->data >> storage. +On systems where the native character encoding is EBCDIC, the bytes in +I<< to->data >> are converted to ASCII. =item B<OSSL_PARAM_OCTET_STRING> |