diff options
| author | Tomas Mraz <tomas@openssl.org> | 2023-07-24 18:05:47 +0200 |
|---|---|---|
| committer | Tomas Mraz <tomas@openssl.org> | 2023-08-08 15:58:59 +0200 |
| commit | 44cb36d04adb737be1aee32908232003deeb67dd (patch) | |
| tree | f1fe8280f92f99a4316db58b3c3b6de628d16110 /ssl/quic/quic_channel.c | |
| parent | bio_ssl.c: Support most ctrls with QUIC based BIO_SSL (diff) | |
| download | openssl-44cb36d04adb737be1aee32908232003deeb67dd.tar.xz openssl-44cb36d04adb737be1aee32908232003deeb67dd.zip | |
Resolve some of the TODO(QUIC) items
For some of the items we add FUTURE/SERVER/TESTING/MULTIPATH
designation to indicate these do not need to be resolved
in QUIC MVP release.
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21539)
Diffstat (limited to 'ssl/quic/quic_channel.c')
| -rw-r--r-- | ssl/quic/quic_channel.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/ssl/quic/quic_channel.c b/ssl/quic/quic_channel.c index 54ccf5d316..af3a1d051a 100644 --- a/ssl/quic/quic_channel.c +++ b/ssl/quic/quic_channel.c @@ -21,8 +21,8 @@ * not suitable for network use. In particular, it does not implement address * validation, anti-amplification or retry logic. * - * TODO(QUIC): Implement address validation and anti-amplification - * TODO(QUIC): Implement retry logic + * TODO(QUIC SERVER): Implement address validation and anti-amplification + * TODO(QUIC SERVER): Implement retry logic */ #define INIT_DCID_LEN 8 @@ -1380,7 +1380,7 @@ static int ch_on_transport_params(const unsigned char *params, case QUIC_TPARAM_PREFERRED_ADDR: { - /* TODO(QUIC): Handle preferred address. */ + /* TODO(QUIC FUTURE): Handle preferred address. */ QUIC_PREFERRED_ADDR pfa; /* @@ -1684,7 +1684,7 @@ static void ch_tick(QUIC_TICK_RESULT *res, void *arg, uint32_t flags) * again because packets that were not previously processable and * were deferred might now be processable. * - * TODO(QUIC): Consider handling this in the yield_secret callback. + * TODO(QUIC FUTURE): Consider handling this in the yield_secret callback. */ } while (ch->have_new_rx_secret); } @@ -1985,7 +1985,7 @@ static void ch_rx_handle_packet(QUIC_CHANNEL *ch) return; /* - * TODO(QUIC): Theoretically this should probably be in the QRX. + * TODO(QUIC FUTURE): Theoretically this should probably be in the QRX. * However because validation is dependent on context (namely the * client's initial DCID) we can't do this cleanly. In the future we * should probably add a callback to the QRX to let it call us (via @@ -2011,8 +2011,8 @@ static void ch_rx_handle_packet(QUIC_CHANNEL *ch) return; /* - * TODO(QUIC): Implement 0-RTT on the server side. We currently do - * not need to implement this as a client can only do 0-RTT if we + * TODO(QUIC 0RTT): Implement 0-RTT on the server side. We currently + * do not need to implement this as a client can only do 0-RTT if we * have given it permission to in a previous session. */ break; @@ -2124,7 +2124,7 @@ static void ch_default_packet_handler(QUIC_URXE *e, void *arg) case QUIC_VERSION_NONE: default: /* Unknown version or proactive version negotiation request, bail. */ - /* TODO(QUIC): Handle version negotiation on server side */ + /* TODO(QUIC SERVER): Handle version negotiation on server side */ goto undesirable; } |