summaryrefslogtreecommitdiffstats
path: root/test/crltest.c
diff options
context:
space:
mode:
authorBernd Edlinger <bernd.edlinger@hotmail.de>2019-01-29 14:16:28 +0100
committerBernd Edlinger <bernd.edlinger@hotmail.de>2019-01-31 19:10:57 +0100
commita727627922b8a9ec6628ffaa2054b4b3833d674b (patch)
treebbce4b293c9abc0f0f54aa91327455c5e01fa2f6 /test/crltest.c
parentBetter phrasing around 1.1.0 (diff)
downloadopenssl-a727627922b8a9ec6628ffaa2054b4b3833d674b.tar.xz
openssl-a727627922b8a9ec6628ffaa2054b4b3833d674b.zip
Fix a memory leak with di2_X509_CRL reuse
Additionally avoid undefined behavior with in-place memcpy in X509_CRL_digest. Fixes #8099 Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/8112)
Diffstat (limited to '')
-rw-r--r--test/crltest.c15
1 files changed, 15 insertions, 0 deletions
diff --git a/test/crltest.c b/test/crltest.c
index 3b0fab774e..6a2ef4e90d 100644
--- a/test/crltest.c
+++ b/test/crltest.c
@@ -357,6 +357,20 @@ static int test_unknown_critical_crl(int n)
return r;
}
+static int test_reuse_crl(void)
+{
+ X509_CRL *reused_crl = CRL_from_strings(kBasicCRL);
+ char *p;
+ BIO *b = glue2bio(kRevokedCRL, &p);
+
+ reused_crl = PEM_read_bio_X509_CRL(b, &reused_crl, NULL, NULL);
+
+ OPENSSL_free(p);
+ BIO_free(b);
+ X509_CRL_free(reused_crl);
+ return 1;
+}
+
int setup_tests(void)
{
if (!TEST_ptr(test_root = X509_from_strings(kCRLTestRoot))
@@ -368,6 +382,7 @@ int setup_tests(void)
ADD_TEST(test_bad_issuer_crl);
ADD_TEST(test_known_critical_crl);
ADD_ALL_TESTS(test_unknown_critical_crl, OSSL_NELEM(unknown_critical_crls));
+ ADD_TEST(test_reuse_crl);
return 1;
}